Support specifying include variables inline#681
Merged
Conversation
jamos-tay
changed the title
yamgent
reviewed
Feb 10, 2019
yamgent
left a comment
yamgent
left a comment
Member
There was a problem hiding this comment.
Just one query, the rest looks good.
jamos-tay
force-pushed
the
variable-data-in-attributes
branch
from
f5e7728 to
32a7e79
Compare
Contributor
Author
|
Rebased, see comment |
yamgent
approved these changes
Feb 11, 2019
Contributor
|
@jamos-tay there was a suggestion from @acjh to use |
Contributor
|
Since the |
Contributor
Author
|
Yeah, I figured |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Enhancement to an existing feature
Fixes #642
What is the rationale for this request?
Provide a simpler syntax for specifying include variables
What changes did you make? (Give an overview)
Authors can include variables inline by adding
var-...attributes:Used
varinstead ofdataas it's more variable related